test(e2e): add automated accessibility (axe-core) gate and fix violations#111
Open
louisbels wants to merge 2 commits into
Open
test(e2e): add automated accessibility (axe-core) gate and fix violations#111louisbels wants to merge 2 commits into
louisbels wants to merge 2 commits into
Conversation
…ions Add a Playwright accessibility suite that runs axe-core (WCAG 2.0/2.1 A+AA) across the app's key UI states — create page, password generator, markdown editor, success/share view, and the note view's burn gate, password gate and decrypted content. A shared `expectNoA11yViolations` helper reuses the existing flow helpers and prints rule + node selectors on failure. Fix the violations the suite surfaced: - color-contrast: white text on the bright `--accent` (#fc5855) was only 3.15:1, below the 4.5:1 AA threshold for normal text. Introduce a darker `--accent-strong` (#dc2626, 4.84:1) for solid CTA buttons/links with white text, leaving `--accent` for text/icons/accents (where it still passes). - label: give the readonly manage-URL input and the password-length range slider accessible names via aria-label. 719 unit tests unchanged; all 23 e2e tests pass (14 existing + 9 new). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0181yWku6hbsnpGnB3VediTB
…y check The decrypted note view animates in via Svelte `in:fade`/`in:fly` (Web Animations API). axe could sample the DOM mid-transition, where half-faded text reports washed-out colors that trip color-contrast (e.g. accent #d44c4a on bg at 4.49:1). At full opacity these elements pass comfortably; the failure was purely a timing race that surfaced on slower CI runners. Finish all running animations in `expectNoA11yViolations` before analyzing so every scan samples the settled, full-opacity state regardless of machine speed. Verified with `playwright test accessibility --repeat-each=3` (27/27 pass). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0181yWku6hbsnpGnB3VediTB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Playwright accessibility suite that runs axe-core (WCAG 2.0/2.1 A+AA)
across the app's key UI states — create page, password generator, markdown
editor, success/share view, and the note view's burn gate, password gate and
decrypted content. A shared
expectNoA11yViolationshelper reuses the existingflow helpers and prints rule + node selectors on failure.
Fix the violations the suite surfaced:
--accent(#fc5855) was only3.15:1, below the 4.5:1 AA threshold for normal text. Introduce a darker
--accent-strong(#dc2626, 4.84:1) for solid CTA buttons/links with whitetext, leaving
--accentfor text/icons/accents (where it still passes).slider accessible names via aria-label.
719 unit tests unchanged; all 23 e2e tests pass (14 existing + 9 new).
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_0181yWku6hbsnpGnB3VediTB